Refactor edit address #13633

atorresveiga · 2025-02-26T22:18:42Z

Part of: #12440

Description

This PR refactors the edit origin address classes to add support for destination addresses. The changes introduced here include:

Reorganize address classes (origin-specific classes under the origin package and the classes used for both flows under the address package)
Update the navigation parameter to include the edit address flow
Update the logic under the WooShippingEditAddressViewModel to use Address instead of OriginShippingAddress
Fix unit tests

In the next PR, I'll be working on the destination address networking and connecting the data with the UI. I will also update the view model unit tests to include tests about the flow

Testing information

Checking that updating the origin address keeps working as expected.

TC1

Open the orders tab
Tap on an order eligible for shipping label creation
Expand the shipment details section
Expand the origin address selection (3 dots)
Tap on the pencil
Update the postal code to make the address unverified
Tap on Validate & Save
Check that the address selection bottom sheet is expanded
Select an address and tap on the bottom button
Exit the screen
Check that the address is updated with the changes from step 6

TC2

Open the orders tab
Tap on an order eligible for shipping label creation
Expand the shipment details section
Expand the origin address selection (3 dots)
Tap on the pencil
Update the email to make the address status as unsaved changes
Tap on Save changes
Exit the screen
Check that the address is updated with the changes from step 6

The tests that have been performed

Checked that the UI

Images/gif

Screen_recording_20250224_072340.mp4

I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

coderabbitai · 2025-02-26T22:18:48Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

atorresveiga · 2025-02-26T22:20:02Z

...m/woocommerce/android/ui/orders/wooshippinglabels/address/WooShippingEditAddressViewModel.kt

@@ -652,3 +701,9 @@ data class InputValue(
        val EMPTY = InputValue("")
    }
 }
+
+@Parcelize
+data class DestinationShippingAddress(


I might move this class to the model package when working on the network layer.

wpmobilebot · 2025-02-26T22:23:43Z

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce-Wear Android
	Platform	⌚️ Wear OS
	Flavor	Jalapeno
	Build Type	Debug
	Commit	`7152d8d`
	Direct Download	`woocommerce-wear-prototype-build-pr13633-7152d8d.apk`

atorresveiga · 2025-02-26T22:25:36Z

...m/woocommerce/android/ui/orders/wooshippinglabels/address/WooShippingEditAddressViewModel.kt

+    }
+
+    @Suppress("UnusedParameter")
+    private fun onUpdateDestinationAddress(editableAddress: EditableAddress) {


In the next pull request, I will focus on the network layer and update the destination address.

wpmobilebot · 2025-02-26T22:36:00Z

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Commit	`7152d8d`
	Direct Download	`woocommerce-prototype-build-pr13633-7152d8d.apk`

codecov-commenter · 2025-02-26T22:42:30Z

Codecov Report

Attention: Patch coverage is 75.75758% with 16 lines in your changes missing coverage. Please review.

Project coverage is 38.08%. Comparing base (3498888) to head (7152d8d).

Files with missing lines	Patch %	Lines
...glabels/address/WooShippingEditAddressViewModel.kt	75.75%	10 Missing and 6 partials ⚠️

Additional details and impacted files

@@                         Coverage Diff                          @@
##             issue/12439-edit-order-navigation   #13633   +/-   ##
====================================================================
  Coverage                                38.07%   38.08%           
+ Complexity                                9068     9058   -10     
====================================================================
  Files                                     2058     2058           
  Lines                                   112768   112804   +36     
  Branches                                 14298    14298           
====================================================================
+ Hits                                     42936    42960   +24     
- Misses                                   65928    65937    +9     
- Partials                                  3904     3907    +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Alejo added 7 commits February 26, 2025 15:12

add destination address data class

ccaccd5

add EditAddressFlow class

8c33670

map OriginShippingAddress -> Address

9b5df8f

update logic to use the different flows

fdb0876

update navigation parameter

21fa9fe

move common classes outside the origin package

3c39865

fix unit tests

7152d8d

atorresveiga added type: task An internally driven task. feature: shipping labels Related to creating, ordering, or printing shipping labels. labels Feb 26, 2025

atorresveiga added this to the 21.9 milestone Feb 26, 2025

atorresveiga requested review from irfano and ThomazFB February 26, 2025 22:18

atorresveiga commented Feb 26, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor edit address #13633

Refactor edit address #13633

atorresveiga commented Feb 26, 2025

coderabbitai bot commented Feb 26, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

atorresveiga Feb 26, 2025 •

edited

Loading

wpmobilebot commented Feb 26, 2025

atorresveiga Feb 26, 2025

wpmobilebot commented Feb 26, 2025

codecov-commenter commented Feb 26, 2025

Refactor edit address #13633

Are you sure you want to change the base?

Refactor edit address #13633

Conversation

atorresveiga commented Feb 26, 2025

Description

Testing information

The tests that have been performed

Images/gif

Reviewer (or Author, in the case of optional code reviews):

coderabbitai bot commented Feb 26, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

atorresveiga Feb 26, 2025 • edited Loading

Choose a reason for hiding this comment

wpmobilebot commented Feb 26, 2025

atorresveiga Feb 26, 2025

Choose a reason for hiding this comment

wpmobilebot commented Feb 26, 2025

codecov-commenter commented Feb 26, 2025

Codecov Report

atorresveiga Feb 26, 2025 •

edited

Loading